Why this conversation
Feedback English for juniors: judge the work, protect the instinct, and give one concrete habit instead of a general lecture.
Dialogue
Jay: Before the code: the instinct to build the helper yourself instead of waiting for someone was right. Keep that.
Sun-woo: But?
Jay: But it exists. rails has formatUnits with the same signature, and it handles the eighteen-decimals edge case yours misses. So the PR should shrink to an import.
Sun-woo: I didn't know rails had it. I searched the repo.
Jay: This repo, right? The habit I'd add is one more search, in rails, before writing anything that feels generic. Five minutes, every time. That's the whole lesson.
Sun-woo: Should I close the PR?
Jay: Rewrite it. The test you wrote is good and rails doesn't have one for that case. Keep the test, swap the implementation, and the PR becomes a contribution to rails instead of a duplicate.
Sun-woo: That's a better PR than the one I opened.
Jay: It usually is, the second time.
Key expressions
| Expression | 뜻 · 쓰이는 자리 |
|---|---|
| before the code | 코드 얘기 전에 |
| the instinct was right | 본능은 맞았다 |
| keep that | 그건 유지하라 |
| shrink to an import | import 하나로 줄어들다 |
| the habit I'd add | 내가 추가하고 싶은 습관 |
| anything that feels generic | 범용적으로 느껴지는 무엇이든 |
| that's the whole lesson | 그게 교훈의 전부다 |
| keep the test, swap the implementation | 테스트는 두고 구현을 바꿔라 |
| a contribution instead of a duplicate | 중복이 아닌 기여 |
| it usually is, the second time | 대개 두 번째가 그렇다 |