Why this conversation
The most useful review move in this genre: agree with the feature in two words, then ask for the paperwork without sounding like a block.
Dialogue
Priya: This adds a pause so we can stop settlement if the oracle goes bad. I think it's uncontroversial.
Jay: The function is. What I can't find in the PR is who can call it, and what un-pauses it.
Priya: Owner only, for now. We'd un-pause by hand once we've looked.
Jay: Reasonable start. I'd want those two sentences somewhere that isn't a code comment. "For now" and "by hand" are what an auditor asks about, not the modifier.
Priya: Where, then?
Jay: A three-column table in the repo: what a human can do, who and how, when we give it up. Even TBD in the third column beats the column not existing.
Priya: It'll be TBD for everything today.
Jay: That's honest. A table full of TBDs is a roadmap. A missing table is a question we answer under pressure later.
Key expressions
| Expression | 뜻 · 쓰이는 자리 |
|---|---|
| it's uncontroversial | 논란의 여지가 없다 |
| who can call it | 누가 호출할 수 있나 |
| what un-pauses it | 무엇이 해제하나 |
| owner only, for now | 지금은 오너만 |
| a reasonable start | 합리적인 출발점 |
| somewhere that isn't a code comment | 코드 주석이 아닌 어딘가에 |
| when we give it up | 언제 내려놓는가 |
| TBD (to be determined) | 미정 |
| beats the column not existing | 열이 없는 것보다 낫다 |
| answer it under pressure later | 나중에 압박 속에서 답하다 |